[PATCH] [lld] Add ArchiveMemoryBuffer.

Rui Ueyama ruiu at google.com
Thu Feb 5 11:59:51 PST 2015

I think no such plumbing is needed. That can be done in a few lines like
this http://reviews.llvm.org/D7445

On Thu, Feb 5, 2015 at 11:21 AM, Shankar Kalpathi Easwaran <
shankarke at gmail.com> wrote:

> I tried making changes and this was the flow.
> instantiateMember -> calls Registry::loadFile(memory buffer) -> calls
> Reader::loadFile(memory buffer) -> calls ELFObjectReader::loadFile ->
> Creates lld::File.
> So memberName and fileName needs to be added to all these calls, and the
> intermediate API's are called from YAML/MachO and there are places it does
> not make sense.
> MemoryBuffer need to owned by lld::File which is not being done currently.
> But with all this change, MemoryBuffer would
> So I feel this is much cleaner. If you see a better way to do this, let me
> know.
> http://reviews.llvm.org/D7428
>   http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150205/733aa6e0/attachment.html>

More information about the llvm-commits mailing list