[PATCH] [lld] Add ArchiveMemoryBuffer.

Shankar Kalpathi Easwaran shankarke at gmail.com
Thu Feb 5 11:21:24 PST 2015


I tried making changes and this was the flow.

instantiateMember -> calls Registry::loadFile(memory buffer) -> calls Reader::loadFile(memory buffer) -> calls ELFObjectReader::loadFile -> Creates lld::File.

So memberName and fileName needs to be added to all these calls, and the intermediate API's are called from YAML/MachO and there are places it does not make sense.

MemoryBuffer need to owned by lld::File which is not being done currently. But with all this change, MemoryBuffer would

So I feel this is much cleaner. If you see a better way to do this, let me know.


http://reviews.llvm.org/D7428

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list