[PATCH] R600/SI: Also enable WQM for image opcodes which calculate LOD

[Michel Dänzer]

On 02.02.2015 17:09, Michel Dänzer wrote:
> On 30.01.2015 23:52, Tom Stellard wrote:
>> On Fri, Jan 30, 2015 at 10:55:38AM +0900, Michel Dänzer wrote:
>>> On 22.01.2015 00:30, Tom Stellard wrote:
>>>> On Wed, Jan 21, 2015 at 01:07:25PM +0900, Michel Dänzer wrote:
>>>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>>>>
>>>>> If whole quad mode isn't enabled for these, the level of detail is
>>>>> calculated incorrectly for pixels along diagonal triangle edges, causing
>>>>> artifacts.
>>>>>
>>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88642
>>>>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> 
> [...]
> 
>>>> Would it be possible to avoid this switch statement by adding a
>>>> new target flag to these tablegen definitions?
>>>
>>> How about the attached v2 patch?
>>>
>>> I'm also attaching another patch which drops enabling WQM for V_INTERP_*
>>> instructions.
>>
>> Hi Michel,
>>
>> These both look good to me.
> 
> Thanks, but it occurred to me in the meantime that I should add some
> test coverage for the changes. I'll add that and resend.

Here are the updated patches with test coverage. I added a third patch
to ensure WQM is enabled for LDS in pixel shaders.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-R600-SI-Also-enable-WQM-for-image-opcodes-which-calc.patch
Type: text/x-patch
Size: 28235 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150203/a9e9b166/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-R600-SI-Don-t-enable-WQM-for-V_INTERP_-instructions-.patch
Type: text/x-patch
Size: 4041 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150203/a9e9b166/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-R600-SI-Amend-a-test-to-ensure-WQM-is-enabled-for-LD.patch
Type: text/x-patch
Size: 887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150203/a9e9b166/attachment-0002.bin>