[PATCH] R600/SI: Also enable WQM for image opcodes which calculate LOD

Michel Dänzer michel at daenzer.net
Mon Feb 2 00:09:58 PST 2015

On 30.01.2015 23:52, Tom Stellard wrote:
> On Fri, Jan 30, 2015 at 10:55:38AM +0900, Michel Dänzer wrote:
>> On 22.01.2015 00:30, Tom Stellard wrote:
>>> On Wed, Jan 21, 2015 at 01:07:25PM +0900, Michel Dänzer wrote:
>>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>>> If whole quad mode isn't enabled for these, the level of detail is
>>>> calculated incorrectly for pixels along diagonal triangle edges, causing
>>>> artifacts.
>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88642
>>>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>


>>> Would it be possible to avoid this switch statement by adding a
>>> new target flag to these tablegen definitions?
>> How about the attached v2 patch?
>> I'm also attaching another patch which drops enabling WQM for V_INTERP_*
>> instructions.
> Hi Michel,
> These both look good to me.

Thanks, but it occurred to me in the meantime that I should add some
test coverage for the changes. I'll add that and resend.

> Do you think the second one is a candidate for the stable branch?

The second patch without the first patch would break lots of pixel
shaders (probably most of them), basically any which use texture
sampling but not derivatives and don't override the level of detail.

However, patch 1 alone or both patches together could go to the stable

Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

More information about the llvm-commits mailing list