[PATCH] [LoopVectorize] Move LoopAccessAnalysis to its own module
anemet at apple.com
Sat Jan 31 00:48:01 PST 2015
Comment at: include/llvm/Analysis/LoopAccessAnalysis.h:183
@@ +182,3 @@
+/// \p Message or \p TheLoop's.
+void emitLoopAnalysis(Report &Message, const Function *F, const Loop *L);
> These functions are really private to the two implementations; having them in the top-level llvm namespace seems somewhat unfortunate. Any thoughts on some better placement?
One option would be to make it a static member function VectorizationReport.
Comment at: include/llvm/Analysis/LoopAccessAnalysis.h:191
@@ +190,3 @@
+/// \p Ptr.
+const SCEV *replaceSymbolicStrideSCEV(ScalarEvolution *SE,
+ ValueToValueMap &PtrToStride,
> We should better document what this does, that PtrToStride is, etc.
Sure. I'll do that. (We may want to further clean this up later and move the symbolic stride logic to LAA as well.)
Should I also make stripIntegerCast a member function of Value? Or is it OK to do that later?
More information about the llvm-commits