[llvm] r227603 - ARM: further correct .fpu directive handling

Renato Golin renato.golin at linaro.org
Fri Jan 30 13:06:49 PST 2015

On 30 January 2015 at 20:48, Saleem Abdulrasool <compnerd at compnerd.org> wrote:
> I hate the clang-format output here, its not very legible IMO.  The change
> here actually is to the *disabled* field.  That is, if you did
> -mfpu=vfpv3-d16 and then did .fpu vfpv3 ... you need to disable the D16
> behavior.  I was hoping that the commit message was sufficient.  Should I
> add a comment to that effect above the table?

Damn, that table got me, again! The comma isn't really telling of
what's on, and I assumed it was a pipe all the way through.

Maybe we do need a short comment and forced formatting, to have
enabled / disabled in separate lines. Something like:

FPUs[] = {
         /* enable */ ARM::FeatureVFP2,
         /* disable */ ARM::FeatureNEON},
         /* enable */ ARM::FeatureVFP2,
         /* disable */ ARM::FeatureNEON},

Sorry for the trouble...


More information about the llvm-commits mailing list