[llvm] r227603 - ARM: further correct .fpu directive handling

[Saleem Abdulrasool]

On Fri, Jan 30, 2015 at 1:06 PM, Renato Golin <renato.golin at linaro.org>
wrote:

> On 30 January 2015 at 20:48, Saleem Abdulrasool <compnerd at compnerd.org>
> wrote:
> > I hate the clang-format output here, its not very legible IMO.  The
> change
> > here actually is to the *disabled* field.  That is, if you did
> > -mfpu=vfpv3-d16 and then did .fpu vfpv3 ... you need to disable the D16
> > behavior.  I was hoping that the commit message was sufficient.  Should I
> > add a comment to that effect above the table?
>
> Damn, that table got me, again! The comma isn't really telling of
> what's on, and I assumed it was a pipe all the way through.
>
> Maybe we do need a short comment and forced formatting, to have
> enabled / disabled in separate lines. Something like:
>
> FPUs[] = {
>      {ARM::VFP,
>          /* enable */ ARM::FeatureVFP2,
>          /* disable */ ARM::FeatureNEON},
>      {ARM::VFPV2,
>          /* enable */ ARM::FeatureVFP2,
>          /* disable */ ARM::FeatureNEON},
>       ...
>

I like this idea.  Ill go ahead and make this change soon.


> Sorry for the trouble...
>
> --renato
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150130/d7894f40/attachment.html>