[llvm] r227318 - [ELFYAML] Provide explicit value for relocation addendums in the test

[Sean Silva]

On Wed, Jan 28, 2015 at 4:22 PM, Simon Atanasyan <simon at atanasyan.com>
wrote:

> Author: atanasyan
> Date: Wed Jan 28 10:22:50 2015
> New Revision: 227318
>
> URL: http://llvm.org/viewvc/llvm-project?rev=227318&view=rev
> Log:
> [ELFYAML] Provide explicit value for relocation addendums in the test
>
> The `Addend` is an optional field of the `Relocation` YAML record. But
> we do not provide its default value while reading it from a YAML file
> and so it might keep uninitialized.
>
> I am going to fix the code by a separate commit. We might either make
> this field mandatory (at least for .rela sections) or specify 0 as
> a default value explicitly.
>

0 default for .rela SGTM.

-- Sean Silva


>
> Modified:
>     llvm/trunk/test/Object/Mips/elf-mips64-rel.yaml
>
> Modified: llvm/trunk/test/Object/Mips/elf-mips64-rel.yaml
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/Mips/elf-mips64-rel.yaml?rev=227318&r1=227317&r2=227318&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/Object/Mips/elf-mips64-rel.yaml (original)
> +++ llvm/trunk/test/Object/Mips/elf-mips64-rel.yaml Wed Jan 28 10:22:50
> 2015
> @@ -79,17 +79,21 @@ Sections:
>        - Offset:      0x20
>          Symbol:      .rodata
>          Type:        R_MIPS_GOT_PAGE
> +        Addend:      0
>        - Offset:      0x24
>          Symbol:      .rodata
>          Type:        R_MIPS_GOT_OFST
> +        Addend:      0
>        - Offset:      0x28
>          Symbol:      printf
>          Type:        R_MIPS_CALL16
> +        Addend:      0
>        - Offset:      0x30
>          Symbol:      printf
>          Type:        R_MIPS_GPREL16
>          Type2:       R_MIPS_LO16
>          SpecSym:     RSS_GP0
> +        Addend:      0
>    - Name:            .rodata
>      Type:            SHT_PROGBITS
>      Flags:           [ SHF_ALLOC ]
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150128/15423243/attachment.html>