<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 28, 2015 at 4:22 PM, Simon Atanasyan <span dir="ltr"><<a href="mailto:simon@atanasyan.com" target="_blank">simon@atanasyan.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: atanasyan<br>
Date: Wed Jan 28 10:22:50 2015<br>
New Revision: 227318<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=227318&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=227318&view=rev</a><br>
Log:<br>
[ELFYAML] Provide explicit value for relocation addendums in the test<br>
<br>
The `Addend` is an optional field of the `Relocation` YAML record. But<br>
we do not provide its default value while reading it from a YAML file<br>
and so it might keep uninitialized.<br>
<br>
I am going to fix the code by a separate commit. We might either make<br>
this field mandatory (at least for .rela sections) or specify 0 as<br>
a default value explicitly.<br></blockquote><div><br></div><div>0 default for .rela SGTM.</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/test/Object/Mips/elf-mips64-rel.yaml<br>
<br>
Modified: llvm/trunk/test/Object/Mips/elf-mips64-rel.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/Mips/elf-mips64-rel.yaml?rev=227318&r1=227317&r2=227318&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/Mips/elf-mips64-rel.yaml?rev=227318&r1=227317&r2=227318&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/Object/Mips/elf-mips64-rel.yaml (original)<br>
+++ llvm/trunk/test/Object/Mips/elf-mips64-rel.yaml Wed Jan 28 10:22:50 2015<br>
@@ -79,17 +79,21 @@ Sections:<br>
       - Offset:      0x20<br>
         Symbol:      .rodata<br>
         Type:        R_MIPS_GOT_PAGE<br>
+        Addend:      0<br>
       - Offset:      0x24<br>
         Symbol:      .rodata<br>
         Type:        R_MIPS_GOT_OFST<br>
+        Addend:      0<br>
       - Offset:      0x28<br>
         Symbol:      printf<br>
         Type:        R_MIPS_CALL16<br>
+        Addend:      0<br>
       - Offset:      0x30<br>
         Symbol:      printf<br>
         Type:        R_MIPS_GPREL16<br>
         Type2:       R_MIPS_LO16<br>
         SpecSym:     RSS_GP0<br>
+        Addend:      0<br>
   - Name:            .rodata<br>
     Type:            SHT_PROGBITS<br>
     Flags:           [ SHF_ALLOC ]<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>