[llvm] r227018 - InstrProf: Add operator!= to coverage counters

[David Blaikie]

On Tue, Jan 27, 2015 at 5:34 PM, Justin Bogner <mail at justinbogner.com>
wrote:

> David Blaikie <dblaikie at gmail.com> writes:
> > On Sat, Jan 24, 2015 at 1:13 PM, Justin Bogner <mail at justinbogner.com>
> wrote:
> >
> >     Author: bogner
> >     Date: Sat Jan 24 15:13:23 2015
> >     New Revision: 227018
> >
> >     URL: http://llvm.org/viewvc/llvm-project?rev=227018&view=rev
> >     Log:
> >     InstrProf: Add operator!= to coverage counters
> >
> >     I'll use this in clang shortly. Also makes the operator definition
> >     style more consistent in this class.
> >
> > Test cases?
>
> I'm not convinced it's valuable to test an operator!= whose
> implementation is literally "return !(LHS == RHS)". If you feel really
> strongly I can write some unit tests for this type, but they'll be
> pretty pointless.
>

You know the last person who said that? Chris. See 188583 and 188582 ;)

(& more or less what Marshall said)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150127/407b3d02/attachment.html>