[PATCH] [2/3] [SimplifyLibCalls] Refactor str/mem libcall handling: Factor out str/mem libcall optimizations
ahmed.bougacha at gmail.com
Tue Jan 27 14:03:40 PST 2015
r227250 should fix the strcpy problems, and now I'm terrified by this
kind of refactoring! At least I learned my lesson.
Anyway, a review would be very welcome, if you have some time.
On Tue, Jan 27, 2015 at 11:59 AM, Ahmed Bougacha
<ahmed.bougacha at gmail.com> wrote:
> On Thu, Jan 8, 2015 at 10:00 AM, Eric Christopher <echristo at gmail.com> wrote:
>> Checking inside the function for the name before doing things feels a bit icky, but I see where you're going with this and don't have a better idea at the moment.
> You were right to be icked-out, it turns out this was broken and the
> existing tests were way too lax ;)
> I'm fixing that by passing the LibFunc::Func around, and making the
> tests extra robust; thankfully it's not too late for 3.6!
>> EMAIL PREFERENCES
More information about the llvm-commits