[PATCH] [2/3] [SimplifyLibCalls] Refactor str/mem libcall handling: Factor out str/mem libcall optimizations

Ahmed Bougacha ahmed.bougacha at gmail.com
Tue Jan 27 11:59:35 PST 2015


On Thu, Jan 8, 2015 at 10:00 AM, Eric Christopher <echristo at gmail.com> wrote:
> Checking inside the function for the name before doing things feels a bit icky, but I see where you're going with this and don't have a better idea at the moment.

You were right to be icked-out, it turns out this was broken and the
existing tests were way too lax  ;)

I'm fixing that by passing the LibFunc::Func around, and making the
tests extra robust; thankfully it's not too late for 3.6!

-Ahmed

> LGTM.
>
> -eric
>
>
> http://reviews.llvm.org/D6540
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>



More information about the llvm-commits mailing list