[PATCH] Improve DAG combine pass on certain IR vector patterns

Quentin Colombet qcolombet at apple.com
Fri Jan 16 16:23:06 PST 2015

On Jan 16, 2015, at 4:19 PM, Fiona Glaser <fglaser at apple.com> wrote:

> Okay, I ported the test case to aarch64 and armv7.

Thanks for checking. That is what I would have suggested.

> My patch doesn’t change the code output with i16 or float vectors. The current status of those is:
> armv7/aarch64 float vectors: ideal code
> armv7 with i16 vectors: bad code, but same for all three IRs
> aarch64 with i16 vectors: bad code, which turns into utterly awful code for the first two out of three IRs.

I thought your patch would have make all the 3 IRs to generate the same not so bad code.
Feel free to double check why this is not the case, but anyway LGTM!


> Fiona

More information about the llvm-commits mailing list