[PATCH] Report fatal errors instead of segfaulting/asserting on a few invalid accesses while reading MachO files.

Filipe Cabecinhas filcab+llvm.phabricator at gmail.com
Tue Jan 13 20:30:01 PST 2015


Rephrase error pointed out by majnemer
Added a test requested by Rafael

Rafael: Extracting that part of the function yields code that's a bit too convoluted. Check which version you prefer (or suggest other changes).


http://reviews.llvm.org/D6945

Files:
  lib/Object/MachOObjectFile.cpp
  test/Object/Inputs/macho-invalid-bad-symbol-index
  test/Object/Inputs/macho-invalid-no-size-for-sections
  test/Object/Inputs/macho-invalid-section-index
  test/Object/Inputs/macho-invalid-symbol-name-past-eof
  test/Object/Inputs/macho-invalid-too-small-load-command
  test/Object/Inputs/macho-invalid-zero-ncmds
  test/Object/Inputs/macho-zero-ncmds
  test/Object/Inputs/macho64-invalid-getsection-index
  test/Object/Inputs/macho64-invalid-incomplete-load-command
  test/Object/Inputs/macho64-invalid-no-size-for-sections
  test/Object/Inputs/macho64-invalid-too-small-load-command
  test/Object/macho-invalid.test
  test/Object/objdump-macho-quirks.test

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6945.18129.patch
Type: text/x-patch
Size: 7521 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150114/d7f6c10d/attachment.bin>


More information about the llvm-commits mailing list