[PATCH] NVTPX: Use MapMetadata() instead of incorrect, custom logic

Justin Holewinski justin.holewinski at gmail.com
Tue Jan 13 18:20:41 PST 2015

This looks reasonable to me.  Thanks for updating this!

On Tue, Jan 13, 2015 at 5:44 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

> NVTPX has its own `remapMDNode()` which (1) does strange things and
> (2) is bitrotting.
> The first patch removes the strange, invalid logic to replace a
> global variable declaration (see the actual
> `DIBuilder::createGlobalVariable()` for what the field *really*
> does -- ignore the comment) with a ConstantInt representing the
> address space.  (It'll mangle any other metadata schema that
> happens to reference global variables, as well.)
> The second patch rewrites the logic to use `MapMetadata()`, so that
> this code doesn't continue to bitrot.
> These aren't really NFC, but it doesn't cause any test failures.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



Justin Holewinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150113/1be0c7b2/attachment.html>

More information about the llvm-commits mailing list