[PATCH] NVTPX: Use MapMetadata() instead of incorrect, custom logic

[Duncan P. N. Exon Smith]

+jholewinski at nvidia.com

> On 2015-Jan-13, at 14:44, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
> NVTPX has its own `remapMDNode()` which (1) does strange things and
> (2) is bitrotting.
> 
> The first patch removes the strange, invalid logic to replace a
> global variable declaration (see the actual
> `DIBuilder::createGlobalVariable()` for what the field *really*
> does -- ignore the comment) with a ConstantInt representing the
> address space.  (It'll mangle any other metadata schema that
> happens to reference global variables, as well.)
> 
> The second patch rewrites the logic to use `MapMetadata()`, so that
> this code doesn't continue to bitrot.
> 
> These aren't really NFC, but it doesn't cause any test failures.

Should have CC'ed you to begin with!  Let me know if these look okay.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-NVPTX-Remove-bogus-remap-logic-for-global-variable-a.patch
Type: application/octet-stream
Size: 1689 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150113/f8990eca/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-NVPTX-Use-MapMetadata-instead-of-custom-stale-untest.patch
Type: application/octet-stream
Size: 4387 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150113/f8990eca/attachment-0001.obj>
-------------- next part --------------