[PATCH] [lld][ELF]: Minimal implementation for ARM static linking

[Rui Ueyama]

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMExecutableWriter.h:9
@@ +8,3 @@
+//===----------------------------------------------------------------------===//
+#ifndef ARM_EXECUTABLE_WRITER_H
+#define ARM_EXECUTABLE_WRITER_H
----------------
ifdef guard should include the path name.

  #ifndef LLD_READER_WRITER_ELF_ARM_ARM_EXECUTABLE_WRITER_H


================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationHandler.h:34
@@ +33,3 @@
+private:
+  ARMTargetLayout<ARMELFType> &_ARMTargetLayout;
+};
----------------
A name beginning with '_' followed by an uppercase character is reserved to the implementation (just like __), so please don't use such name. s/_ARMTargetLayout/_armTargetLayout/.

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMTarget.h:1
@@ +1,2 @@
+//===--------- lib/ReaderWriter/ELF/ARM/ARMTarget.h -----------------------===//
+//
----------------
Why do we need this almost-empty header? Can't we directly include ARMLinkingContext.h?

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMTargetHandler.h:62
@@ +61,3 @@
+  std::unique_ptr<ARMTargetLayout<ARMELFType>> _ARMTargetLayout;
+  std::unique_ptr<ARMTargetRelocationHandler> _ARMRelocationHandler;
+};
----------------
They conflict with reserved names.

http://reviews.llvm.org/D6716

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/