[PATCH] Convert CoreInputGraph.

[Rui Ueyama]

Thank you for reviewing!

On Wed, Jan 7, 2015 at 5:53 AM, kledzik at apple.com <kledzik at apple.com> wrote:

> LGTM
>
> Two comments:
>
> 1. This refactoring has taken so many steps, I'm beginning to think one
> big patch where we can see the end design might have been better...
>

I'll upload my local branch to somewhere (maybe to github) so that you can
see the final source tree there. For code review purpose, I think a series
of small patches would be better.


> 2. The ErrorFile concept makes me wonder if that should be the approach
> for all parseFile() implementations.  Rather than having a result parameter
> is that is a vector they append to and returning an error_code, they simply
> return a vector of Files and any errors are encoded as ErrorFiles in that
> vector.
>

I agree. That's my plan.


>
>
> http://reviews.llvm.org/D6653
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150107/29f28eb5/attachment.html>