[PATCH] Convert CoreInputGraph.

kledzik at apple.com kledzik at apple.com
Tue Jan 6 12:53:30 PST 2015


LGTM

Two comments:

1. This refactoring has taken so many steps, I'm beginning to think one big patch where we can see the end design might have been better...
2. The ErrorFile concept makes me wonder if that should be the approach for all parseFile() implementations.  Rather than having a result parameter is that is a vector they append to and returning an error_code, they simply return a vector of Files and any errors are encoded as ErrorFiles in that vector.


http://reviews.llvm.org/D6653

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list