[compiler-rt] r224839 - [asan] Disable __sanitizer_cov_dump registration on Windows.

[Alexey Samsonov]

Could you write it as
  if (!SANITIZER_WINDOWS && !common_flags()->coverage_direct)
instead?

On Thu, Dec 25, 2014 at 7:11 AM, Evgeniy Stepanov <eugeni.stepanov at gmail.com
> wrote:

> Author: eugenis
> Date: Thu Dec 25 09:11:00 2014
> New Revision: 224839
>
> URL: http://llvm.org/viewvc/llvm-project?rev=224839&view=rev
> Log:
> [asan] Disable __sanitizer_cov_dump registration on Windows.
>
> Looks like we can't use atexit() during ASan initialization on Windows.
>
> Modified:
>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc
>
> Modified:
> compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc
> URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc?rev=224839&r1=224838&r2=224839&view=diff
>
> ==============================================================================
> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc
> (original)
> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc
> Thu Dec 25 09:11:00 2014
> @@ -590,7 +590,9 @@ void InitializeCoverage(bool enabled, co
>    coverage_enabled = enabled;
>    coverage_dir = dir;
>    if (enabled) coverage_data.Init();
> +#if !SANITIZER_WINDOWS
>    if (!common_flags()->coverage_direct) Atexit(__sanitizer_cov_dump);
> +#endif
>  }
>
>  void ReInitializeCoverage(bool enabled, const char *dir) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141227/1c70152e/attachment.html>