<div dir="ltr">Could you write it as<div>  if (!SANITIZER_WINDOWS && !common_flags()->coverage_direct)</div><div>instead?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 25, 2014 at 7:11 AM, Evgeniy Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: eugenis<br>
Date: Thu Dec 25 09:11:00 2014<br>
New Revision: 224839<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=224839&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=224839&view=rev</a><br>
Log:<br>
[asan] Disable __sanitizer_cov_dump registration on Windows.<br>
<br>
Looks like we can't use atexit() during ASan initialization on Windows.<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc?rev=224839&r1=224838&r2=224839&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc?rev=224839&r1=224838&r2=224839&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc Thu Dec 25 09:11:00 2014<br>
@@ -590,7 +590,9 @@ void InitializeCoverage(bool enabled, co<br>
   coverage_enabled = enabled;<br>
   coverage_dir = dir;<br>
   if (enabled) coverage_data.Init();<br>
+#if !SANITIZER_WINDOWS<br>
   if (!common_flags()->coverage_direct) Atexit(__sanitizer_cov_dump);<br>
+#endif<br>
 }<br>
<br>
 void ReInitializeCoverage(bool enabled, const char *dir) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</div>