[PATCH] Separate file parsing from File's constructors.

[Rui Ueyama]

On Fri, Dec 12, 2014 at 1:56 PM, Simon Atanasyan <simon at atanasyan.com>
wrote:

> LGTM
>
>
>
>
>
> ================
>
> Comment at: include/lld/Core/File.h:159
>
> @@ +158,3 @@
>
> +  /// memory buffer passed to this file's constructor.
>
> +  virtual std::error_code doParse() { return std::error_code(); }
>
> +
>
> ----------------
>
> Can we make this virtual method abstract?


We could, but there are more than a few File subclasses that doesn't need
this method, so in order to keep the boilerplate small, I'd like to keep
this.


>
>
> http://reviews.llvm.org/D6633
>
>
>
> EMAIL PREFERENCES
>
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141212/60d6c021/attachment.html>