<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Dec 12, 2014 at 1:56 PM, Simon Atanasyan <span dir="ltr"><<a href="mailto:simon@atanasyan.com" target="_blank">simon@atanasyan.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">LGTM<br>
<br>
<br>
<br>
<br>
<br>
================<br>
<br>
Comment at: include/lld/Core/File.h:159<br>
<br>
@@ +158,3 @@<br>
<br>
+  /// memory buffer passed to this file's constructor.<br>
<br>
+  virtual std::error_code doParse() { return std::error_code(); }<br>
<br>
+<br>
<br>
----------------<br>
<br>
Can we make this virtual method abstract?</blockquote><div><br></div><div>We could, but there are more than a few File subclasses that doesn't need this method, so in order to keep the boilerplate small, I'd like to keep this.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
<br>
<br>
<a href="http://reviews.llvm.org/D6633" target="_blank">http://reviews.llvm.org/D6633</a><br>
<br>
<br>
<br>
EMAIL PREFERENCES<br>
<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
<br>
<br>
</div></div></blockquote></div><br></div></div>