[PATCH] ARM: Add support for ARM modified immediate syntax - Take 3

Tim Northover t.p.northover at gmail.com
Mon Dec 1 09:54:31 PST 2014


Hi Asiri,

Thanks for the AsmParser explanation and updated patch, I see now. But I think there's still one slight bit of streamlining we can do in the InstPrinter:

================
Comment at: lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp:1332-1338
@@ +1331,9 @@
+
+  if (Rot == 0) {
+    O << "#"
+      << markup("<imm:")
+      << Bits
+      << markup(">");
+    return;
+  }
+
----------------
Isn't this now redundant? Looks like it would be covered fine by the logic below.

http://reviews.llvm.org/D6408






More information about the llvm-commits mailing list