[PATCH] ARM: Add support for ARM modified immediate syntax - Take 3

Asiri Rathnayake asiri.rathnayake at arm.com
Mon Dec 1 07:48:40 PST 2014


>>! In D6408#12, @rmaprath wrote:
> Hi Tim,
> 
>> ================
>> Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:4463-4465
>> @@ +4462,5 @@
>> +
>> +  if (Parser.getTok().isNot(AsmToken::Comma)) {
>> +    // Consider [mov r0, #-10], which is aliased with mvn. We cannot fail
>> +    // the parse here.
>> +    Operands.push_back(ARMOperand::CreateImm(Imm1Exp, Sx1, Ex1));
>> ----------------
>> I don't understand this one. Wouldn't that example have been covered by AsmToken::EndOfStatement above?
> 
> -10 (0xfffffff6 in two's complement) is not representable as a modified immediate. 

I.e (Enc == -1).

--Asiri

http://reviews.llvm.org/D6408






More information about the llvm-commits mailing list