[llvm] r220548 - Update test/MC/ARM/coff-debugging-secrel.ll expectations to fix breakage caused by r220544

[Saleem Abdulrasool]

On Thu, Oct 23, 2014 at 11:40 PM, Timur Iskhodzhanov <timurrrr at google.com>
wrote:

> Hi Saleem,
>
> Are you sure you're doing the right thing in that test?
>

What do you mean by the right thing?  They are ensuring that the
relocations that we emit are of the correct type.  If you have a better way
to test that, Im open to suggestions.  I know that debug info generation
has broken a number of times in the past, so I think that having tests for
it is a good idea.


> These expectations are likely to break every time we make progress on
> CVLT DI generation...
>

Yes, I expect that they will change as you change the representation of the
data.  Ideally, we would verify that we emit the correct debug information
for the various platforms and formats (and versions).

––
> Tim
>
> 2014-10-23 23:24 GMT-07:00 Timur Iskhodzhanov <timurrrr at google.com>:
> > Author: timurrrr
> > Date: Fri Oct 24 01:24:07 2014
> > New Revision: 220548
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=220548&view=rev
> > Log:
> > Update test/MC/ARM/coff-debugging-secrel.ll expectations to fix breakage
> caused by r220544
> >
> > Modified:
> >     llvm/trunk/test/MC/ARM/coff-debugging-secrel.ll
> >
> > Modified: llvm/trunk/test/MC/ARM/coff-debugging-secrel.ll
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/coff-debugging-secrel.ll?rev=220548&r1=220547&r2=220548&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/test/MC/ARM/coff-debugging-secrel.ll (original)
> > +++ llvm/trunk/test/MC/ARM/coff-debugging-secrel.ll Fri Oct 24 01:24:07
> 2014
> > @@ -42,8 +42,10 @@ entry:
> >
> >  ; CHECK-MSVC: Relocations [
> >  ; CHECK-MSVC:   Section {{.*}} .debug$S {
> > -; CHECK-MSVC:     0xC IMAGE_REL_ARM_SECREL function
> > -; CHECK-MSVC:     0x10 IMAGE_REL_ARM_SECTION function
> > +; CHECK-MSVC:     0x2C IMAGE_REL_ARM_SECREL function
> > +; CHECK-MSVC:     0x30 IMAGE_REL_ARM_SECTION function
> > +; CHECK-MSVC:     0x48 IMAGE_REL_ARM_SECREL function
> > +; CHECK-MSVC:     0x4C IMAGE_REL_ARM_SECTION function
> >  ; CHECK-MSVC:   }
> >  ; CHECK-MSVC: ]
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141024/fe2f666e/attachment.html>