<div dir="ltr">On Thu, Oct 23, 2014 at 11:40 PM, Timur Iskhodzhanov <span dir="ltr"><<a href="mailto:timurrrr@google.com" target="_blank">timurrrr@google.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Saleem,<br>
<br>
Are you sure you're doing the right thing in that test?<br></blockquote><div><br></div><div>What do you mean by the right thing?  They are ensuring that the relocations that we emit are of the correct type.  If you have a better way to test that, Im open to suggestions.  I know that debug info generation has broken a number of times in the past, so I think that having tests for it is a good idea.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
These expectations are likely to break every time we make progress on<br>
CVLT DI generation...<br></blockquote><div><br></div><div>Yes, I expect that they will change as you change the representation of the data.  Ideally, we would verify that we emit the correct debug information for the various platforms and formats (and versions).</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
––<br>
Tim<br>
<br>
2014-10-23 23:24 GMT-07:00 Timur Iskhodzhanov <<a href="mailto:timurrrr@google.com">timurrrr@google.com</a>>:<br>
<div class="HOEnZb"><div class="h5">> Author: timurrrr<br>
> Date: Fri Oct 24 01:24:07 2014<br>
> New Revision: 220548<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=220548&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=220548&view=rev</a><br>
> Log:<br>
> Update test/MC/ARM/coff-debugging-secrel.ll expectations to fix breakage caused by r220544<br>
><br>
> Modified:<br>
>     llvm/trunk/test/MC/ARM/coff-debugging-secrel.ll<br>
><br>
> Modified: llvm/trunk/test/MC/ARM/coff-debugging-secrel.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/coff-debugging-secrel.ll?rev=220548&r1=220547&r2=220548&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/coff-debugging-secrel.ll?rev=220548&r1=220547&r2=220548&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/MC/ARM/coff-debugging-secrel.ll (original)<br>
> +++ llvm/trunk/test/MC/ARM/coff-debugging-secrel.ll Fri Oct 24 01:24:07 2014<br>
> @@ -42,8 +42,10 @@ entry:<br>
><br>
>  ; CHECK-MSVC: Relocations [<br>
>  ; CHECK-MSVC:   Section {{.*}} .debug$S {<br>
> -; CHECK-MSVC:     0xC IMAGE_REL_ARM_SECREL function<br>
> -; CHECK-MSVC:     0x10 IMAGE_REL_ARM_SECTION function<br>
> +; CHECK-MSVC:     0x2C IMAGE_REL_ARM_SECREL function<br>
> +; CHECK-MSVC:     0x30 IMAGE_REL_ARM_SECTION function<br>
> +; CHECK-MSVC:     0x48 IMAGE_REL_ARM_SECREL function<br>
> +; CHECK-MSVC:     0x4C IMAGE_REL_ARM_SECTION function<br>
>  ; CHECK-MSVC:   }<br>
>  ; CHECK-MSVC: ]<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org
</div></div>