[lld] r220185 - [ELF] Add demangle test to XFAIL

Rui Ueyama ruiu at google.com
Tue Oct 21 13:12:23 PDT 2014


Addressed in r220315.

On Tue, Oct 21, 2014 at 12:52 PM, Rui Ueyama <ruiu at google.com> wrote:

> On Tue, Oct 21, 2014 at 12:41 PM, Ed Maste <emaste at freebsd.org> wrote:
>
>> On 21 October 2014 15:13, Rui Ueyama <ruiu at google.com> wrote:
>> >
>> > It feels to me that HAVE_CXXABI_H is defined properly in a sense
>> because on
>> > FreeBSD the header is not actually usable unless you include other
>> header
>> > beforehand. Other systems don't have such issue.
>>
>> We could, ending up with something like:
>>
>> // FreeBSD 10.0 has cxxabi.h but fails to define HAVE_CXXABI_H due to
>> // header dependency issues.
>> #if defined(HAVE_CXXABI_H) || defined (__FreeBSD__)
>>
>> It's ugly, but I agree something like this is preferable to XFAIL.
>>
>
> I agree. This doesn't look good but still better than a XFAIL.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141021/2041292c/attachment.html>


More information about the llvm-commits mailing list