[PATCH] [dwarfdump] Prettyprint DW_AT_APPLE_property_attribute bitfield values.

Frederic Riss friss at apple.com
Thu Oct 9 15:41:19 PDT 2014


================
Comment at: test/DebugInfo/dwarfdump-objc.test:21
@@ +20,3 @@
+CHECK-NOT: TAG
+CHECK:   DW_AT_APPLE_property_attribute {{.*}} (0x0c ( DW_APPLE_PROPERTY_assign, DW_APPLE_PROPERTY_readwrite ) )
+
----------------
dblaikie wrote:
> (0x0c ( DW_APPLE_PROPERTY_foo, bar ) )
> 
> seems inconsistent use of space - there's no leading space before the 0x0c, but there's a leading space before DW (& then trailing spaces for both ')'.
> 
> I'd probably be in favor of no leading or trailing spaces, but I'm not sure what this looks like compared to various other parts of the dump output.
Agreed, it doesn't look nice. I just copied the formatting from the native dwarfdump, but I like it better with leading and trailing spaces (there isn't any prior example of that kind of dump input I think, so just pick what seems nicer). I'll resubmit shortly.

http://reviews.llvm.org/D5689






More information about the llvm-commits mailing list