[PATCH] [dwarfdump] Prettyprint DW_AT_APPLE_property_attribute bitfield values.

David Blaikie dblaikie at gmail.com
Thu Oct 9 15:19:59 PDT 2014


================
Comment at: test/DebugInfo/dwarfdump-objc.test:21
@@ +20,3 @@
+CHECK-NOT: TAG
+CHECK:   DW_AT_APPLE_property_attribute {{.*}} (0x0c ( DW_APPLE_PROPERTY_assign, DW_APPLE_PROPERTY_readwrite ) )
+
----------------
(0x0c ( DW_APPLE_PROPERTY_foo, bar ) )

seems inconsistent use of space - there's no leading space before the 0x0c, but there's a leading space before DW (& then trailing spaces for both ')'.

I'd probably be in favor of no leading or trailing spaces, but I'm not sure what this looks like compared to various other parts of the dump output.

http://reviews.llvm.org/D5689






More information about the llvm-commits mailing list