[PATCH] [dwarfdump] Prettyprint DW_AT_APPLE_property_attribute bitfield values.

Alexey Samsonov vonosmas at gmail.com
Wed Oct 8 18:17:22 PDT 2014


================
Comment at: lib/DebugInfo/DWARFDebugInfoEntry.cpp:87
@@ +86,3 @@
+      break;
+    OS << ", ";
+  } while (true);
----------------
friss wrote:
> samsonov wrote:
> > This would output an extra trailing comma
> Nope because the condition just above exits if we've handled the last bit. (The actual loop exit test is in the middle of the loop. I find this idiom less clumsy than having a bool lying around telling if you are in the first iteration or not, but I can understand opinions might differ on this point).
Oh, sorry, I missed that =/ The code is fine as is, I have no strong preference.

http://reviews.llvm.org/D5689






More information about the llvm-commits mailing list