[PATCH] [dwarfdump] Prettyprint DW_AT_APPLE_property_attribute bitfield values.

Frederic Riss friss at apple.com
Wed Oct 8 17:57:37 PDT 2014


================
Comment at: lib/DebugInfo/DWARFDebugInfoEntry.cpp:87
@@ +86,3 @@
+      break;
+    OS << ", ";
+  } while (true);
----------------
samsonov wrote:
> This would output an extra trailing comma
Nope because the condition just above exits if we've handled the last bit. (The actual loop exit test is in the middle of the loop. I find this idiom less clumsy than having a bool lying around telling if you are in the first iteration or not, but I can understand opinions might differ on this point).

http://reviews.llvm.org/D5689






More information about the llvm-commits mailing list