[PATCH] Factor the Unit section parsing into the DWARFUnitSection class.

Frederic Riss friss at apple.com
Fri Oct 3 17:12:00 PDT 2014

Comment at: lib/DebugInfo/DWARFUnit.h:39
@@ -38,1 +38,3 @@
+  void parse(DWARFContext &C, StringRef SectionData, const RelocAddrMap &Map);
+  void parseDWO(DWARFContext &C, StringRef SectionData, const RelocAddrMap &Map);
samsonov wrote:
> Can these methods take const DWARFContext::Section & instead of StringRef/RelocAddrMap ?
Nope because you can't forward declare nested structs and including DWARFContext.h in DWARFUnit.h isn't possible (circular dependency). We could unnest the Section struct from the Context object to allow this.


More information about the llvm-commits mailing list