[PATCH] Factor the Unit section parsing into the DWARFUnitSection class.

Alexey Samsonov vonosmas at gmail.com
Fri Oct 3 17:04:50 PDT 2014


I think this is fine for a incremental change (but see a comment below).

================
Comment at: lib/DebugInfo/DWARFUnit.h:39
@@ -38,1 +38,3 @@
 
+  void parse(DWARFContext &C, StringRef SectionData, const RelocAddrMap &Map);
+  void parseDWO(DWARFContext &C, StringRef SectionData, const RelocAddrMap &Map);
----------------
Can these methods take const DWARFContext::Section & instead of StringRef/RelocAddrMap ?

http://reviews.llvm.org/D5522






More information about the llvm-commits mailing list