[PATCH] Add -bare option to llvm-objdump

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Sep 10 14:30:19 PDT 2014


>>   Diagnostic tests cannot depend on the per-host default.  Tests only need
>> updating (a tedious process) if -bare output changes.
>
>
> In the discussion on llvmdev, Rafael seemed to suggest that llvm-objdump is
> not really meant for testing purposes
> (https://groups.google.com/forum/#!msg/llvm-dev/KnUNBPG1CRA/tJmlFt7IB3wJ).
> Rafael, what do you think about the present patch?

Not quiet. What I meant is that, unlike llvm-readobj, llvm-objdump was
not *only* a testing tool.
In that regard it is like llvm-nm: it is a user tool, but there is
nothing wrong with using it
for testing.

> Also, it seems like almost all of these tests are using -filetype=obj output
> only to pass it to llvm-objdump. Is there a reason they aren't directly
> doing asm output?

If the tests can be update to check assembly or to use llvm-mc instead
of llc I agree that that
is the best fix.

I think my main issue with the patch is probably that there is no
-bare option it the gnu objdump.
Do we really need the extra feature? It seems better to have
llvm-objdump behave like the
system one: always symbolize. How many tests would have to be updated?
For example, I noticed
that the patch changes test/CodeGen/AArch64/arm64-simplest-elf.ll, but
I don't think that that test's
CHECK lines would actually be affected if llvm-objdump started symbolizing.

Cheers,
Rafael



More information about the llvm-commits mailing list