[PATCH] Add -bare option to llvm-objdump

[Sean Silva]

On Wed, Sep 10, 2014 at 1:38 PM, Steve King <kingshizzle at gmail.com> wrote:

> The -bare option keeps objdump output consistent with test expectations
> regardless of host platform.  As discussed on the list, default
> llvm-objdump output could change per host:  GNU style for Linux, otools for
> Apple, etc.


I think this needs some discussion in LLVMDev. I don't see the point in
slaving to reproduce the system tool's output when we don't match the
command-line options.


>   Diagnostic tests cannot depend on the per-host default.  Tests only need
> updating (a tedious process) if -bare output changes.
>

In the discussion on llvmdev, Rafael seemed to suggest that llvm-objdump is
not really meant for testing purposes (
https://groups.google.com/forum/#!msg/llvm-dev/KnUNBPG1CRA/tJmlFt7IB3wJ).
Rafael, what do you think about the present patch?

Also, it seems like almost all of these tests are using -filetype=obj
output only to pass it to llvm-objdump. Is there a reason they aren't
directly doing asm output?

-- Sean Silva


>
> If this is agreeable, I'd like to keep the -bare option and -d consistency
> patches unified since both touch the same line in large number of
> diagnostic test files.
>
> http://reviews.llvm.org/D5279
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140910/1311c496/attachment.html>