[PATCH] Move options from MergedLoadStoreMotion to PassManagerBuilder

Chad Rosier mcrosier at codeaurora.org
Wed Sep 10 12:53:25 PDT 2014


Assuming my minor nit is addressed, LGTM.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:235
@@ -230,2 +234,3 @@
   if (OptLevel > 1) {
-    MPM.add(createMergedLoadStoreMotionPass()); // Merge load/stores in diamond
+    if (EnableMLSM)
+      MPM.add(
----------------
I'd prefer something like:

if (EnableMLSM)  // Merge load/stores in diamond
  MPM.add(createMergedLoadStoreMotionPass());

or maybe

if (EnableMLSM)
  MPM.add(createMergedLoadStoreMotionPass()); // Merge ld/st in diamond

http://reviews.llvm.org/D5299






More information about the llvm-commits mailing list