[PATCH] Move options from MergedLoadStoreMotion to PassManagerBuilder

[Gerolf Hoflehner]

Thanks, Chad! Addressed in Committed revision 217538

-Gerolf

On Sep 10, 2014, at 12:53 PM, Chad Rosier <mcrosier at codeaurora.org> wrote:

> Assuming my minor nit is addressed, LGTM.
> 
> ================
> Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:235
> @@ -230,2 +234,3 @@
>   if (OptLevel > 1) {
> -    MPM.add(createMergedLoadStoreMotionPass()); // Merge load/stores in diamond
> +    if (EnableMLSM)
> +      MPM.add(
> ----------------
> I'd prefer something like:
> 
> if (EnableMLSM)  // Merge load/stores in diamond
>  MPM.add(createMergedLoadStoreMotionPass());
> 
> or maybe
> 
> if (EnableMLSM)
>  MPM.add(createMergedLoadStoreMotionPass()); // Merge ld/st in diamond
> 
> http://reviews.llvm.org/D5299
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140910/baa12b60/attachment.html>