[lld] r217324 - Remove dead code.

Rui Ueyama ruiu at google.com
Mon Sep 8 15:18:31 PDT 2014


On Mon, Sep 8, 2014 at 3:17 PM, Juergen Ributzka <juergen at apple.com> wrote:

>
> On Sep 6, 2014, at 6:44 PM, Chandler Carruth <chandlerc at google.com> wrote:
>
>
> On Sat, Sep 6, 2014 at 6:23 PM, Rui Ueyama <ruiu at google.com> wrote:
>
>> Author: ruiu
>> Date: Sat Sep  6 20:23:16 2014
>> New Revision: 217324
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=217324&view=rev
>> Log:
>> Remove dead code.
>>
>> Modified:
>>     lld/trunk/include/lld/Core/File.h
>>     lld/trunk/lib/Core/File.cpp
>>
>> Modified: lld/trunk/include/lld/Core/File.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/File.h?rev=217324&r1=217323&r2=217324&view=diff
>>
>> ==============================================================================
>> --- lld/trunk/include/lld/Core/File.h (original)
>> +++ lld/trunk/include/lld/Core/File.h Sat Sep  6 20:23:16 2014
>> @@ -39,7 +39,7 @@ class LinkingContext;
>>  /// are destroyed when the File object is destroyed.
>>  class File {
>>  public:
>> -  virtual ~File();
>> +  virtual ~File() {}
>>
>
> This removes the initial out-of-line virtual function which provides the
> key function for the class allowing its code to be emitted in a single
> translation unit. Maybe this should be kept?
>
>
> +1
>

Done in r217392.

> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140908/d03d93b6/attachment.html>


More information about the llvm-commits mailing list