<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Sep 8, 2014 at 3:17 PM, Juergen Ributzka <span dir="ltr"><<a href="mailto:juergen@apple.com" target="_blank">juergen@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div><div class="h5"><blockquote type="cite"><div>On Sep 6, 2014, at 6:44 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>> wrote:</div><br><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_extra"><div class="gmail_quote"><br>On Sat, Sep 6, 2014 at 6:23 PM, Rui Ueyama<span> </span><span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span><span> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="overflow:hidden">Author: ruiu<br>Date: Sat Sep  6 20:23:16 2014<br>New Revision: 217324<br><br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project?rev=217324&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=217324&view=rev</a><br>Log:<br>Remove dead code.<br><br>Modified:<br>   <span> </span>lld/trunk/include/lld/Core/File.h<br>   <span> </span>lld/trunk/lib/Core/File.cpp<br><br>Modified: lld/trunk/include/lld/Core/File.h<br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/File.h?rev=217324&r1=217323&r2=217324&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/File.h?rev=217324&r1=217323&r2=217324&view=diff</a><br>==============================================================================<br>--- lld/trunk/include/lld/Core/File.h (original)<br>+++ lld/trunk/include/lld/Core/File.h Sat Sep  6 20:23:16 2014<br>@@ -39,7 +39,7 @@ class LinkingContext;<br> /// are destroyed when the File object is destroyed.<br> class File {<br> public:<br>-  virtual ~File();<br>+  virtual ~File() {}</div></blockquote></div><br>This removes the initial out-of-line virtual function which provides the key function for the class allowing its code to be emitted in a single translation unit. Maybe this should be kept?</div></div></div></blockquote><div><br></div></div></div>+1</div></div></blockquote><div> </div><div>Done in r217392.</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><span class=""><div><blockquote type="cite"><div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">_______________________________________________</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">llvm-commits mailing list</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="mailto:llvm-commits@cs.uiuc.edu" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">llvm-commits@cs.uiuc.edu</a><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></span></div></blockquote></div><br></div></div>