[Patch] Removing static initializers from TimeValue

Chris Bieneman beanz at apple.com
Thu Aug 28 16:49:29 PDT 2014


constexpr isn't supported by MSVC until 2013's CTP. I will remove the consts and commit.

Thanks,
-Chris

On Aug 28, 2014, at 4:46 PM, Chandler Carruth <chandlerc at google.com> wrote:

> No need for 'const' on a return type.
> 
> I wonder if we could use constexpr and make TimeValue a literal type? If so, that seems mildly preferable. If not, oh well, your patch still LGTM with the const removed from the return type.
> 
> 
> On Thu, Aug 28, 2014 at 3:21 PM, Chris Bieneman <beanz at apple.com> wrote:
> This patch is some small code cleanup to remove a few static initializers and the corresponding global constants from TimeValue.
> 
> -Chris
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140828/75c1a4b9/attachment.html>


More information about the llvm-commits mailing list