<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">constexpr isn't supported by MSVC until 2013's CTP. I will remove the consts and commit.<div><br></div><div>Thanks,</div><div>-Chris</div><div><br><div><div>On Aug 28, 2014, at 4:46 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">No need for 'const' on a return type.<div><br></div><div>I wonder if we could use constexpr and make TimeValue a literal type? If so, that seems mildly preferable. If not, oh well, your patch still LGTM with the const removed from the return type.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Aug 28, 2014 at 3:21 PM, Chris Bieneman <span dir="ltr"><<a href="mailto:beanz@apple.com" target="_blank">beanz@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This patch is some small code cleanup to remove a few static initializers and the corresponding global constants from TimeValue.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Chris<br>
<br>
</font></span><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div></body></html>