[PATCH] Use attachLowHighPC also for compile unit DIE

Frédéric Riss friss at apple.com
Thu Aug 28 13:39:13 PDT 2014

> On 28 Aug 2014, at 20:13, Frédéric Riss <friss at apple.com> wrote:
>> On 28 Aug 2014, at 20:01, David Blaikie <dblaikie at gmail.com <mailto:dblaikie at gmail.com>> wrote:
>> Do we have existing test coverage for the subprogram case? I imagine we do somewhere (try breaking it and see which tests fail) though it might not be a nice/tidy as your test case. Perhaps you could add the CU coverage to the same test case (& possibly clean it up a bit if it's not as legible as your new case)
> I can try to do that.

Here is a new patch piggybacking the testing onto 2 existing tests. This way we verify compile_unit, subprogram and lexical_scope encodings.

In the lexical scope test, I dropped the -NEXT constraint on the pattern as it would require duplicating the whole CHECK patterns (a CHECK-V4-NEXT needs a previous CHECK-V4). I wasn’t sure which way is better, I can of course keep all the -NEXT constraints and duplicate the whole pattern 2 times.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140828/ea2c94ed/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: attachLowHighPC.diff
Type: application/octet-stream
Size: 3142 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140828/ea2c94ed/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140828/ea2c94ed/attachment-0001.html>

More information about the llvm-commits mailing list