<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 28 Aug 2014, at 20:13, Frédéric Riss <<a href="mailto:friss@apple.com" class="">friss@apple.com</a>> wrote:</div><div class=""><div style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" class=""><div class=""><br class="Apple-interchange-newline">On 28 Aug 2014, at 20:01, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><br class=""></div></div></div></div></blockquote><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class="">Do we have existing test coverage for the subprogram case? I imagine we do somewhere (try breaking it and see which tests fail) though it might not be a nice/tidy as your test case. Perhaps you could add the CU coverage to the same test case (& possibly clean it up a bit if it's not as legible as your new case)<br class=""></div></div></div></div></div></blockquote><div class=""><br class=""></div><div class="">I can try to do that.</div></div></div></blockquote><br class=""></div><div>Here is a new patch piggybacking the testing onto 2 existing tests. This way we verify compile_unit, subprogram and lexical_scope encodings.</div><div><br class=""></div><div>In the lexical scope test, I dropped the -NEXT constraint on the pattern as it would require duplicating the whole CHECK patterns (a CHECK-V4-NEXT needs a previous CHECK-V4). I wasn’t sure which way is better, I can of course keep all the -NEXT constraints and duplicate the whole pattern 2 times.</div><div><br class=""></div><div>Fred</div><div></div></body></html>