[llvm] r216359 - Support/APFloat: unique_ptr-ify temp arrays
chandlerc at google.com
Mon Aug 25 09:33:44 PDT 2014
On Mon, Aug 25, 2014 at 9:20 AM, David Blaikie <dblaikie at gmail.com> wrote:
> Same feedback as for 216358 (be explicit with cv qualifiers, consider
> using one variable rather than two, consider using
> std::vector/SmallVector rather than unique_ptr<T>)
Dylan, can you please back out some of these changes and get pre-commit
review so that we don't need to make identical comments on every commit? It
seems like these aren't quite in the "obvious" bucket yet....
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits