[llvm] r216359 - Support/APFloat: unique_ptr-ify temp arrays

[David Blaikie]

Same feedback as for 216358 (be explicit with cv qualifiers, consider
using one variable rather than two, consider using
std::vector/SmallVector rather than unique_ptr<T[]>)

On Sun, Aug 24, 2014 at 5:58 PM, Dylan Noblesmith <nobled at dreamwidth.org> wrote:
> Author: nobled
> Date: Sun Aug 24 19:58:10 2014
> New Revision: 216359
>
> URL: http://llvm.org/viewvc/llvm-project?rev=216359&view=rev
> Log:
> Support/APFloat: unique_ptr-ify temp arrays
>
> Modified:
>     llvm/trunk/lib/Support/APFloat.cpp
>
> Modified: llvm/trunk/lib/Support/APFloat.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/APFloat.cpp?rev=216359&r1=216358&r2=216359&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Support/APFloat.cpp (original)
> +++ llvm/trunk/lib/Support/APFloat.cpp Sun Aug 24 19:58:10 2014
> @@ -1722,7 +1722,8 @@ APFloat::remainder(const APFloat &rhs)
>      return fs;
>
>    int parts = partCount();
> -  integerPart *x = new integerPart[parts];
> +  auto XOwner = make_unique<integerPart[]>(parts);
> +  auto x = XOwner.get();
>    bool ignored;
>    fs = V.convertToInteger(x, parts * integerPartWidth, true,
>                            rmNearestTiesToEven, &ignored);
> @@ -1741,7 +1742,6 @@ APFloat::remainder(const APFloat &rhs)
>
>    if (isZero())
>      sign = origSign;    // IEEE754 requires this
> -  delete[] x;
>    return fs;
>  }
>
> @@ -1762,7 +1762,8 @@ APFloat::mod(const APFloat &rhs, roundin
>        return fs;
>
>      int parts = partCount();
> -    integerPart *x = new integerPart[parts];
> +    auto XOwner = make_unique<integerPart[]>(parts);
> +    auto x = XOwner.get();
>      bool ignored;
>      fs = V.convertToInteger(x, parts * integerPartWidth, true,
>                              rmTowardZero, &ignored);
> @@ -1781,7 +1782,6 @@ APFloat::mod(const APFloat &rhs, roundin
>
>      if (isZero())
>        sign = origSign;    // IEEE754 requires this
> -    delete[] x;
>    }
>    return fs;
>  }
> @@ -2284,15 +2284,14 @@ APFloat::convertFromSignExtendedInteger(
>
>    if (isSigned &&
>        APInt::tcExtractBit(src, srcCount * integerPartWidth - 1)) {
> -    integerPart *copy;
> +    auto C = make_unique<integerPart[]>(srcCount);
> +    auto copy = C.get();
>
>      /* If we're signed and negative negate a copy.  */
>      sign = true;
> -    copy = new integerPart[srcCount];
>      APInt::tcAssign(copy, src, srcCount);
>      APInt::tcNegate(copy, srcCount);
>      status = convertFromUnsignedParts(copy, srcCount, rounding_mode);
> -    delete [] copy;
>    } else {
>      sign = false;
>      status = convertFromUnsignedParts(src, srcCount, rounding_mode);
> @@ -2545,7 +2544,6 @@ APFloat::convertFromDecimalString(String
>      /* Overflow and round.  */
>      fs = handleOverflow(rounding_mode);
>    } else {
> -    integerPart *decSignificand;
>      unsigned int partCount;
>
>      /* A tight upper bound on number of bits required to hold an
> @@ -2554,7 +2552,8 @@ APFloat::convertFromDecimalString(String
>         tcMultiplyPart.  */
>      partCount = static_cast<unsigned int>(D.lastSigDigit - D.firstSigDigit) + 1;
>      partCount = partCountForBits(1 + 196 * partCount / 59);
> -    decSignificand = new integerPart[partCount + 1];
> +    auto DecSignificandOwner = make_unique<integerPart[]>(partCount + 1);
> +    auto decSignificand = DecSignificandOwner.get();
>      partCount = 0;
>
>      /* Convert to binary efficiently - we do almost all multiplication
> @@ -2595,8 +2594,6 @@ APFloat::convertFromDecimalString(String
>      category = fcNormal;
>      fs = roundSignificandWithExponent(decSignificand, partCount,
>                                        D.exponent, rounding_mode);
> -
> -    delete [] decSignificand;
>    }
>
>    return fs;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits