[PATCH] ARM: Enable DP copy, load and store instructions for FPv4-SP

Renato Golin renato.golin at linaro.org
Thu Aug 21 02:04:46 PDT 2014


================
Comment at: test/CodeGen/ARM/aapcs-hfa-code.ll:79
@@ -80,2 +78,3 @@
 ; CHECK-M4F: movs [[ONEHI:r[0-9]+]], #0
+; CHECK-M4F: movs [[ONELO:r[0-9]+]], #0
 ; CHECK-M4F: movt [[ONEHI]], #16368
----------------
A bit fragile this change, no? Shouldn't this also be a DAG check?

================
Comment at: test/CodeGen/Thumb2/float-ops.ll:3
@@ +2,3 @@
+; RUN: llc < %s -mtriple=thumbv7-none-eabihf -mcpu=cortex-m4 | FileCheck %s -check-prefix=CHECK -check-prefix=SP
+; RUN: llc < %s -mtriple=thumbv7-none-eabihf -mcpu=cortex-a8 | FileCheck %s -check-prefix=CHECK -check-prefix=DP
+
----------------
This one still has some check redundancy. Sorry for being picky, but I fear people will later change checks without properly making sure it makes sense for both DP and SP.

http://reviews.llvm.org/D4907






More information about the llvm-commits mailing list