[PATCH] llvm-objdump bug may hide a single-byte instruction near a label.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Wed Aug 13 08:23:42 PDT 2014


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:499
@@ -497,1 +498,3 @@
+      // The end is either the section end or the beginning of the next symbol.
+      // If this symbol has the same address as the next symbol, then skip it.
       uint64_t Start = Symbols[si].first;
----------------
The first line in the comment about the initialization of End. The second line is about the "if (Start == End)".

It would probably be better to split the comment.

http://reviews.llvm.org/D4868






More information about the llvm-commits mailing list