[PATCH] llvm-objdump bug may hide a single-byte instruction near a label.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Aug 13 08:20:28 PDT 2014


On 12 August 2014 19:48, Steve King <kingshizzle at gmail.com> wrote:
> I also wondered about the best location for the input file.  The bug is not specific to x86 and there is precedence for x86 files in the Inputs directory, so I just chose that location.  I don't care where the test input ultimately lands, but I'll leave it as-is unless somebody insists to move it.

The issue is not the location of the object file, it is the location
of the .test file. We support running the tests with the x86 backend
disabled. If the test is in the X86 directory, it will be correctly
skipped. Where it is now we would get a false failure.

See test/Object/X86/objdump-trivial-object.test for an example.

Cheers,
Rafael




More information about the llvm-commits mailing list