[PATCH] Darwin vararg parameters support in assembler macros

Kevin Enderby enderby at apple.com
Fri Jul 25 10:53:52 PDT 2014


Hi Stepan,

Jim, Tim and I just spoke about this at the end of our staff meeting.  One of us will take a look at this soon.  But please be aware none of us are familiar with GAS’s vararg parameters support in assembler macros.  Also pretty sure I did not do the implementation of the assembler macro support in llvm-mc.  So it make take us some time to come up to speed on this.

We did agree that there is no need to mix this into the existing darwin positional parameters.  And keeping it simple by making sure it works with GAS style assembler macros only is fine.  So if you want to simplify the patch in that direction that would be OK.

At the end of the day we want to make sure that the existing darwin assembler style macros works as we do have a fair bit of code here that uses them.  So if you can enable uses of GAS style vararg parameters support as an option that would be fine.

Kev

On Jul 25, 2014, at 12:57 AM, Stepan Dyatkovskiy <stpworld at narod.ru> wrote:

> Hi Kevin,
> Jim asked me to invite you into "Darwin varargs parameters in asm macros" discussion.
> I didn't find you in phabricator users, so I just forwarded this mail to you, so you could be kept in touch.
> 
> Thanks!
> -Stepan
> 
> Stepan Dyatkovskiy wrote:
>> +Kevin
>> 
>> http://reviews.llvm.org/D3507
>> 
>> 
> 





More information about the llvm-commits mailing list